diff options
| author |   Christoph Hellwig <hch@lst.de> | 2022-11-01 16:00:46 +0100 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2022-11-02 08:35:34 -0600 |
| commit | 8537380bb9882c201db60a1eb201aac6e74083e8 (patch) | |
| tree | 8e24998a609bc4ce247893890a461c6021336407 | |
| parent | nvme-apple: don't unquiesce the I/O queues in apple_nvme_reset_work (diff) | |
| download | wireguard-linux-8537380bb9882c201db60a1eb201aac6e74083e8.tar.xz wireguard-linux-8537380bb9882c201db60a1eb201aac6e74083e8.zip | |
blk-mq: skip non-mq queues in blk_mq_quiesce_queue
For submit_bio based queues there is no (S)RCU critical section during
I/O submission and thus nothing to wait for in blk_mq_wait_quiesce_done,
so skip doing any synchronization. No non-mq driver should be calling
this, but for now we have core callers that unconditionally call into it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20221101150050.3510-11-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/blk-mq.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index a78538586a40..a03abadfe4c6 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -280,7 +280,9 @@ EXPORT_SYMBOL_GPL(blk_mq_wait_quiesce_done); void blk_mq_quiesce_queue(struct request_queue *q) { blk_mq_quiesce_queue_nowait(q); - blk_mq_wait_quiesce_done(q); + /* nothing to wait for non-mq queues */ + if (queue_is_mq(q)) + blk_mq_wait_quiesce_done(q); } EXPORT_SYMBOL_GPL(blk_mq_quiesce_queue); |