aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorCong Wang <cong.wang@bytedance.com>2021-04-02 22:27:15 -0700
committerDaniel Borkmann <daniel@iogearbox.net>2021-04-06 23:26:04 +0200
commit928dc406802dc4547b5ef84c3075fe144d4cbcf1 (patch)
treee9e158f3376f57844c505b83d919fb146178aad0
parentlibbpf: Fix KERNEL_VERSION macro (diff)
downloadwireguard-linux-928dc406802dc4547b5ef84c3075fe144d4cbcf1.tar.xz
wireguard-linux-928dc406802dc4547b5ef84c3075fe144d4cbcf1.zip
bpf, udp: Remove some pointless comments
These comments in udp_bpf_update_proto() are copied from the original TCP code and apparently do not apply to UDP. Just remove them. Reported-by: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: John Fastabend <john.fastabend@gmail.com> Link: https://lore.kernel.org/bpf/20210403052715.13854-1-xiyou.wangcong@gmail.com
-rw-r--r--net/ipv4/udp_bpf.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv4/udp_bpf.c b/net/ipv4/udp_bpf.c
index 7d5c4ebf42fe..4a7e38c5d842 100644
--- a/net/ipv4/udp_bpf.c
+++ b/net/ipv4/udp_bpf.c
@@ -110,7 +110,6 @@ int udp_bpf_update_proto(struct sock *sk, bool restore)
if (restore) {
sk->sk_write_space = psock->saved_write_space;
- /* Pairs with lockless read in sk_clone_lock() */
WRITE_ONCE(sk->sk_prot, psock->sk_proto);
return 0;
}
@@ -118,7 +117,6 @@ int udp_bpf_update_proto(struct sock *sk, bool restore)
if (sk->sk_family == AF_INET6)
udp_bpf_check_v6_needs_rebuild(psock->sk_proto);
- /* Pairs with lockless read in sk_clone_lock() */
WRITE_ONCE(sk->sk_prot, &udp_bpf_prots[family]);
return 0;
}