diff options
| author |   Mickaël Salaün <mic@digikod.net> | 2025-05-28 16:44:25 +0200 |
|---|---|---|
| committer | Mickaël Salaün <mic@digikod.net> | 2025-06-19 13:55:38 +0200 |
| commit | 94a7ce26428d3a7ceb46c503ed726160578b9fcc (patch) | |
| tree | ea9e77d402670b68f4e975f465b2caf639e4532a | |
| parent | Linux 6.16-rc2 (diff) | |
| download | wireguard-linux-94a7ce26428d3a7ceb46c503ed726160578b9fcc.tar.xz wireguard-linux-94a7ce26428d3a7ceb46c503ed726160578b9fcc.zip | |
selftests/landlock: Fix readlink check
The audit_init_filter_exe() helper incorrectly checks the readlink(2)
error because an unsigned integer is used to store the result. Use a
signed integer for this check.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/aDbFwyZ_fM-IO7sC@stanley.mountain
Fixes: 6a500b22971c ("selftests/landlock: Add tests for audit flags and domain IDs")
Reviewed-by: Günther Noack <gnoack@google.com>
Link: https://lore.kernel.org/r/20250528144426.1709063-1-mic@digikod.net
Signed-off-by: Mickaël Salaün <mic@digikod.net>
| -rw-r--r-- | tools/testing/selftests/landlock/audit.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/tools/testing/selftests/landlock/audit.h b/tools/testing/selftests/landlock/audit.h index 18a6014920b5..b16986aa6442 100644 --- a/tools/testing/selftests/landlock/audit.h +++ b/tools/testing/selftests/landlock/audit.h @@ -403,11 +403,12 @@ static int audit_init_filter_exe(struct audit_filter *filter, const char *path) /* It is assume that there is not already filtering rules. */ filter->record_type = AUDIT_EXE; if (!path) { - filter->exe_len = readlink("/proc/self/exe", filter->exe, - sizeof(filter->exe) - 1); - if (filter->exe_len < 0) + int ret = readlink("/proc/self/exe", filter->exe, + sizeof(filter->exe) - 1); + if (ret < 0) return -errno; + filter->exe_len = ret; return 0; } |