diff options
| author |   Dejin Zheng <zhengdejin5@gmail.com> | 2020-03-23 23:05:55 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-03-23 22:00:02 -0700 |
| commit | 9c6464dcffa0ee42144c343f51aef3d26dbada05 (patch) | |
| tree | 308728b767cbec40ff5f0b7a310882ddff267fd9 | |
| parent | net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the code (diff) | |
| download | wireguard-linux-9c6464dcffa0ee42144c343f51aef3d26dbada05.tar.xz wireguard-linux-9c6464dcffa0ee42144c343f51aef3d26dbada05.zip | |
net: phy: aquantia: use phy_read_mmd_poll_timeout() to simplify the code
use phy_read_mmd_poll_timeout() to replace the poll codes for
simplify aqr107_wait_reset_complete() function.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/aquantia_main.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c index 837d5eaf9e76..41e7c1432497 100644 --- a/drivers/net/phy/aquantia_main.c +++ b/drivers/net/phy/aquantia_main.c @@ -434,16 +434,11 @@ static int aqr107_set_tunable(struct phy_device *phydev, */ static int aqr107_wait_reset_complete(struct phy_device *phydev) { - int val, retries = 100; - - do { - val = phy_read_mmd(phydev, MDIO_MMD_VEND1, VEND1_GLOBAL_FW_ID); - if (val < 0) - return val; - msleep(20); - } while (!val && --retries); + int val; - return val ? 0 : -ETIMEDOUT; + return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1, + VEND1_GLOBAL_FW_ID, val, val != 0, + 20000, 2000000, false); } static void aqr107_chip_info(struct phy_device *phydev) |