diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-11-10 18:23:07 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-01-20 14:22:50 +0100 |
| commit | a86367803838b369fe5486ac18771d14723c258c (patch) | |
| tree | 6ecd035c623d8ce3932cd5b04f6f399a79de1c14 | |
| parent | driver core: location: Free struct acpi_pld_info *pld before return false (diff) | |
| download | wireguard-linux-a86367803838b369fe5486ac18771d14723c258c.tar.xz wireguard-linux-a86367803838b369fe5486ac18771d14723c258c.zip | |
drivers: base: transport_class: fix possible memory leak
Current some drivers(like iscsi) call transport_register_device()
failed, they don't call transport_destroy_device() to release the
memory allocated in transport_setup_device(), because they don't
know what was done, it should be internal thing to release the
resource in register function. So fix this leak by calling destroy
function inside register function.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221110102307.3492557-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | include/linux/transport_class.h | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/include/linux/transport_class.h b/include/linux/transport_class.h index 63076fb835e3..2efc271a96fa 100644 --- a/include/linux/transport_class.h +++ b/include/linux/transport_class.h @@ -70,8 +70,14 @@ void transport_destroy_device(struct device *); static inline int transport_register_device(struct device *dev) { + int ret; + transport_setup_device(dev); - return transport_add_device(dev); + ret = transport_add_device(dev); + if (ret) + transport_destroy_device(dev); + + return ret; } static inline void |