diff options
| author |   Jinjie Ruan <ruanjinjie@huawei.com> | 2024-10-30 09:21:47 +0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2024-10-31 19:36:25 -0700 |
| commit | bc74d329ceba23f998ead4f716266da5afe319f7 (patch) | |
| tree | 3bcc4eccadcffa72ab2219842b9add3481c60509 | |
| parent | selftests/net: Fix ./ns-XXXXXX not cleanup (diff) | |
| download | wireguard-linux-bc74d329ceba23f998ead4f716266da5afe319f7.tar.xz wireguard-linux-bc74d329ceba23f998ead4f716266da5afe319f7.zip | |
netlink: Remove the dead code in netlink_proto_init()
In the error path of netlink_proto_init(), frees the already allocated
bucket table for new hash tables in a loop, but it is going to panic,
so it is not necessary to clean up the resources, just remove the
dead code.
Suggested-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20241030012147.357400-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/netlink/af_netlink.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 0a9287fadb47..52a7c7233cab 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2935,12 +2935,8 @@ static int __init netlink_proto_init(void) for (i = 0; i < MAX_LINKS; i++) { if (rhashtable_init(&nl_table[i].hash, - &netlink_rhashtable_params) < 0) { - while (--i > 0) - rhashtable_destroy(&nl_table[i].hash); - kfree(nl_table); + &netlink_rhashtable_params) < 0) goto panic; - } } netlink_add_usersock_entry(); |