diff options
| author |   Ilia Mirkin <imirkin@alum.mit.edu> | 2021-03-07 12:48:53 -0500 |
|---|---|---|
| committer |   Karol Herbst <kherbst@redhat.com> | 2021-11-12 23:46:04 +0100 |
| commit | bd6e07e72f37f34535bec7eebc807e5fcfe37b43 (patch) | |
| tree | 2d53b599ee1808c42d61ca077e6ba32b300e2f4c | |
| parent | nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable (diff) | |
| download | wireguard-linux-bd6e07e72f37f34535bec7eebc807e5fcfe37b43.tar.xz wireguard-linux-bd6e07e72f37f34535bec7eebc807e5fcfe37b43.zip | |
drm/nouveau/kms/nv04: use vzalloc for nv04_display
The struct is giant, and triggers an order-7 allocation (512K). There is
no reason for this to be kmalloc-type memory, so switch to vmalloc. This
should help loading nouveau on low-memory and/or long-running systems.
Reported-by: Nathan E. Egge <unlord@xiph.org>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: stable@vger.kernel.org
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Link: https://gitlab.freedesktop.org/drm/nouveau/-/merge_requests/10
| -rw-r--r-- | drivers/gpu/drm/nouveau/dispnv04/disp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/nouveau/dispnv04/disp.c b/drivers/gpu/drm/nouveau/dispnv04/disp.c index 7739f46470d3..99fee4d8cd31 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv04/disp.c @@ -205,7 +205,7 @@ nv04_display_destroy(struct drm_device *dev) nvif_notify_dtor(&disp->flip); nouveau_display(dev)->priv = NULL; - kfree(disp); + vfree(disp); nvif_object_unmap(&drm->client.device.object); } @@ -223,7 +223,7 @@ nv04_display_create(struct drm_device *dev) struct nv04_display *disp; int i, ret; - disp = kzalloc(sizeof(*disp), GFP_KERNEL); + disp = vzalloc(sizeof(*disp)); if (!disp) return -ENOMEM; |