diff options
| author |   Michael Chan <michael.chan@broadcom.com> | 2020-09-20 21:08:59 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-09-20 19:04:45 -0700 |
| commit | c07fa08f02f4053b51dae1a6ee08bc644dc7846d (patch) | |
| tree | c7bb46cee8d075719518b4a6e3b0ce7755643306 | |
| parent | bnxt_en: Fix HWRM_FUNC_QSTATS_EXT firmware call. (diff) | |
| download | wireguard-linux-c07fa08f02f4053b51dae1a6ee08bc644dc7846d.tar.xz wireguard-linux-c07fa08f02f4053b51dae1a6ee08bc644dc7846d.zip | |
bnxt_en: Fix wrong flag value passed to HWRM_PORT_QSTATS_EXT fw call.
The wrong flag value caused the firmware call to return actual port
counters instead of the counter masks. This messed up the counter
overflow logic and caused erratic extended port counters to be
displayed under ethtool -S.
Fixes: 531d1d269c1d ("bnxt_en: Retrieve hardware masks for port counters.")
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index d527c9c0fc9d..7b7e8b7883c8 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -3853,7 +3853,7 @@ static void bnxt_init_stats(struct bnxt *bp) tx_masks = stats->hw_masks; tx_count = sizeof(struct tx_port_stats_ext) / 8; - flags = FUNC_QSTATS_EXT_REQ_FLAGS_COUNTER_MASK; + flags = PORT_QSTATS_EXT_REQ_FLAGS_COUNTER_MASK; rc = bnxt_hwrm_port_qstats_ext(bp, flags); if (rc) { mask = (1ULL << 40) - 1; |