diff options
| author |   Christian Brauner <brauner@kernel.org> | 2024-11-25 15:10:07 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-02 11:25:10 +0100 |
| commit | caf6bf48f902e8e353f124325dd635d143331476 (patch) | |
| tree | 0fe9a4cf12e2ac36acd63c29dc923bb835d05698 | |
| parent | aio: avoid pointless cred reference count bump (diff) | |
| download | wireguard-linux-caf6bf48f902e8e353f124325dd635d143331476.tar.xz wireguard-linux-caf6bf48f902e8e353f124325dd635d143331476.zip | |
binfmt_misc: avoid pointless cred reference count bump
file->f_cred already holds a reference count that is stable during the
operation.
Link: https://lore.kernel.org/r/20241125-work-cred-v2-11-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/binfmt_misc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index 3270c2158552..6a3a16f91051 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -829,9 +829,9 @@ static ssize_t bm_register_write(struct file *file, const char __user *buffer, * didn't matter much as only a privileged process could open * the register file. */ - old_cred = override_creds(get_new_cred(file->f_cred)); + old_cred = override_creds(file->f_cred); f = open_exec(e->interpreter); - put_cred(revert_creds(old_cred)); + revert_creds(old_cred); if (IS_ERR(f)) { pr_notice("register: failed to install interpreter file %s\n", e->interpreter); |