diff options
| author |   Konstantin Meskhidze <konstantin.meskhidze@huawei.com> | 2023-09-05 18:12:22 +0800 |
|---|---|---|
| committer |   Richard Weinberger <richard@nod.at> | 2023-10-28 23:18:12 +0200 |
| commit | d81efd66106c03771ffc8637855a6ec24caa6350 (patch) | |
| tree | b78dfa9992f9b4791c1dfbb18af36abb78154615 | |
| parent | ubi: fastmap: Add control in 'UBI_IOCATT' ioctl to reserve PEBs for filling pools (diff) | |
| download | wireguard-linux-d81efd66106c03771ffc8637855a6ec24caa6350.tar.xz wireguard-linux-d81efd66106c03771ffc8637855a6ec24caa6350.zip | |
ubifs: fix possible dereference after free
'old_idx' could be dereferenced after free via 'rb_link_node' function
call.
Fixes: b5fda08ef213 ("ubifs: Fix memleak when insert_old_idx() failed")
Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
| -rw-r--r-- | fs/ubifs/tnc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c index 6b7d95b65f4b..f4728e65d1bd 100644 --- a/fs/ubifs/tnc.c +++ b/fs/ubifs/tnc.c @@ -65,6 +65,7 @@ static void do_insert_old_idx(struct ubifs_info *c, else { ubifs_err(c, "old idx added twice!"); kfree(old_idx); + return; } } rb_link_node(&old_idx->rb, parent, p); |