diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-09-22 14:58:47 +0300 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2020-09-22 20:18:41 +0530 |
| commit | da75ba2482658a0d9ea5245fadfea6b464fab7a3 (patch) | |
| tree | 8ce03f408fb42a2b3f55b5ac432b53469c85ffdb | |
| parent | dmaengine: dmatest: Check list for emptiness before access its last entry (diff) | |
| download | wireguard-linux-da75ba2482658a0d9ea5245fadfea6b464fab7a3.tar.xz wireguard-linux-da75ba2482658a0d9ea5245fadfea6b464fab7a3.zip | |
dmaengine: dmatest: Return boolean result directly in filter()
There is no need to have a conditional for boolean expression when
function returns bool. Drop unnecessary code and return boolean
result directly.
While at it, drop unneeded casting from void *.
Cc: Vladimir Murzin <vladimir.murzin@arm.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200922115847.30100-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/dmatest.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index 00f288bd377c..a3a172173e34 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -1058,13 +1058,7 @@ static int dmatest_add_channel(struct dmatest_info *info, static bool filter(struct dma_chan *chan, void *param) { - struct dmatest_params *params = param; - - if (!dmatest_match_channel(params, chan) || - !dmatest_match_device(params, chan->device)) - return false; - else - return true; + return dmatest_match_channel(param, chan) && dmatest_match_device(param, chan->device); } static void request_channels(struct dmatest_info *info, |