aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorBard Liao <yung-chuan.liao@linux.intel.com>2025-06-26 14:09:52 +0800
committerVinod Koul <vkoul@kernel.org>2025-07-21 10:43:20 +0530
commitdba7d9dbfdc4389361ff3a910e767d3cfca22587 (patch)
tree954da12354feab29f74c5b5362a2f83c4cffbaba
parentsoundwire: debugfs: move debug statement outside of error handling (diff)
downloadwireguard-linux-dba7d9dbfdc4389361ff3a910e767d3cfca22587.tar.xz
wireguard-linux-dba7d9dbfdc4389361ff3a910e767d3cfca22587.zip
soundwire: stream: restore params when prepare ports fail
The bus->params should be restored if the stream is failed to prepare. The issue exists since beginning. The Fixes tag just indicates the first commit that the commit can be applied to. Fixes: 17ed5bef49f4 ("soundwire: add missing newlines in dynamic debug logs") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Link: https://lore.kernel.org/r/20250626060952.405996-1-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r--drivers/soundwire/stream.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index a4bea742b5d9..38c9dbd35606 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -1510,7 +1510,7 @@ static int _sdw_prepare_stream(struct sdw_stream_runtime *stream,
if (ret < 0) {
dev_err(bus->dev, "Prepare port(s) failed ret = %d\n",
ret);
- return ret;
+ goto restore_params;
}
}