diff options
| author |   Michał Mirosław <mirq-linux@rere.qmqm.pl> | 2026-07-02 18:24:40 +0200 |
|---|---|---|
| committer |   Alex Deucher <alexander.deucher@amd.com> | 2026-07-15 09:15:43 -0400 |
| commit | dc6022da45b9abec5f2fc8ef7055d2b8afe1d0b9 (patch) | |
| tree | 72b19b136904a631cd22400f09ef8d27d080a292 | |
| parent | drm/amd/ras: initialize CPER after XGMI reset on init (diff) | |
drm/amd/pm/smu7: make SMU message reports more readable
Make the lines greppable by removing an extra EOL and report the
status only once - after the reply is detected.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Reviewed-by: George Zhang <george.zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
| -rw-r--r-- | drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c index 3e0068a6aeb2..2c190f599ff8 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c @@ -134,14 +134,6 @@ int smu7_send_msg_to_smc(struct pp_hwmgr *hwmgr, uint16_t msg) PHM_WAIT_FIELD_UNEQUAL(hwmgr, SMC_RESP_0, SMC_RESP, 0); - ret = PHM_READ_FIELD(hwmgr->device, SMC_RESP_0, SMC_RESP); - - if (ret == 0xFE) - dev_dbg(adev->dev, "last message was not supported\n"); - else if (ret != 1) - dev_info(adev->dev, - "\nlast message was failed ret is %d\n", ret); - cgs_write_register(hwmgr->device, mmSMC_RESP_0, 0); cgs_write_register(hwmgr->device, mmSMC_MESSAGE_0, msg); @@ -150,10 +142,9 @@ int smu7_send_msg_to_smc(struct pp_hwmgr *hwmgr, uint16_t msg) ret = PHM_READ_FIELD(hwmgr->device, SMC_RESP_0, SMC_RESP); if (ret == 0xFE) - dev_dbg(adev->dev, "message %x was not supported\n", msg); + dev_dbg(adev->dev, "SMU message %#x was not supported\n", msg); else if (ret != 1) - dev_dbg(adev->dev, - "failed to send message %x ret is %d \n", msg, ret); + dev_info(adev->dev, "SMU message %#x failed: response is %d\n", msg, ret); return 0; } |