diff options
| author |   Dan Carpenter <dan.carpenter@linaro.org> | 2025-06-25 10:21:53 -0500 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-06-28 17:24:17 +0200 |
| commit | e35a5d814525006f043b29bffd1bbdcb549b23c5 (patch) | |
| tree | f36ae34f9519151949fe493b4b351afe1bf04589 | |
| parent | dt-bindings: usb: genesys,gl850g: add downstream facing ports (diff) | |
| download | wireguard-linux-e35a5d814525006f043b29bffd1bbdcb549b23c5.tar.xz wireguard-linux-e35a5d814525006f043b29bffd1bbdcb549b23c5.zip | |
usb: gadget: u_serial: remove some dead code
There is no need to check if "port" is NULL. We already verified that it
is non-NULL. It's a stack variable and can't be modified by a different
thread. Delete this dead code.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Prashanth K <prashanth.k@oss.qualcomm.com>
Link: https://lore.kernel.org/r/685c1413.050a0220.1a8223.d0b9@mx.google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/gadget/function/u_serial.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index ab544f6824be..96756a489d6a 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -1505,13 +1505,7 @@ void gserial_suspend(struct gserial *gser) spin_unlock_irqrestore(&serial_port_lock, flags); if (!gserial_wakeup_host(gser)) return; - - /* Check if port is valid after acquiring lock back */ spin_lock_irqsave(&serial_port_lock, flags); - if (!port) { - spin_unlock_irqrestore(&serial_port_lock, flags); - return; - } } spin_lock(&port->port_lock); |