diff options
| author |   Breno Leitao <leitao@debian.org> | 2025-07-10 05:57:26 -0700 |
|---|---|---|
| committer |   Corey Minyard <corey@minyard.net> | 2025-07-10 07:59:43 -0500 |
| commit | ec50ec378e3fd83bde9b3d622ceac3509a60b6b5 (patch) | |
| tree | 6c8f7974c7e98dbc0ad43ec3cc2b208e6e053bdc | |
| parent | char: ipmi: remove redundant variable 'type' and check (diff) | |
| download | wireguard-linux-ec50ec378e3fd83bde9b3d622ceac3509a60b6b5.tar.xz wireguard-linux-ec50ec378e3fd83bde9b3d622ceac3509a60b6b5.zip | |
ipmi: Use dev_warn_ratelimited() for incorrect message warnings
During BMC firmware upgrades on live systems, the ipmi_msghandler
generates excessive "BMC returned incorrect response" warnings
while the BMC is temporarily offline. This can flood system logs
in large deployments.
Replace dev_warn() with dev_warn_ratelimited() to throttle these
warnings and prevent log spam during BMC maintenance operations.
Signed-off-by: Breno Leitao <leitao@debian.org>
Message-ID: <20250710-ipmi_ratelimit-v1-1-6d417015ebe9@debian.org>
Signed-off-by: Corey Minyard <corey@minyard.net>
| -rw-r--r-- | drivers/char/ipmi/ipmi_msghandler.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 064944ae9fdc..8e9050f99e9e 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -4607,10 +4607,10 @@ return_unspecified: * The NetFN and Command in the response is not even * marginally correct. */ - dev_warn(intf->si_dev, - "BMC returned incorrect response, expected netfn %x cmd %x, got netfn %x cmd %x\n", - (msg->data[0] >> 2) | 1, msg->data[1], - msg->rsp[0] >> 2, msg->rsp[1]); + dev_warn_ratelimited(intf->si_dev, + "BMC returned incorrect response, expected netfn %x cmd %x, got netfn %x cmd %x\n", + (msg->data[0] >> 2) | 1, msg->data[1], + msg->rsp[0] >> 2, msg->rsp[1]); goto return_unspecified; } |