diff options
| author |   Vasundhara Volam <vasundhara-v.volam@broadcom.com> | 2020-09-20 21:08:57 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-09-20 19:04:44 -0700 |
| commit | f0f47b2f8cbc22e6e611ef6cc988f5452e5aec3f (patch) | |
| tree | 17dfba40719e0c6e385e8b4d23119e662a6ac8ce | |
| parent | bnxt_en: Protect bnxt_set_eee() and bnxt_set_pauseparam() with mutex. (diff) | |
| download | wireguard-linux-f0f47b2f8cbc22e6e611ef6cc988f5452e5aec3f.tar.xz wireguard-linux-f0f47b2f8cbc22e6e611ef6cc988f5452e5aec3f.zip | |
bnxt_en: Return -EOPNOTSUPP for ETHTOOL_GREGS on VFs.
Debug firmware commands are not supported on VFs to read registers.
This patch avoids logging unnecessary access_denied error on VFs
when user calls ETHTOOL_GREGS.
By returning error in get_regs_len() method on the VF, the get_regs()
method will not be called.
Fixes: b5d600b027eb ("bnxt_en: Add support for 'ethtool -d'")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 6c751013798d..fecdfd875af1 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -1322,6 +1322,9 @@ static int bnxt_get_regs_len(struct net_device *dev) struct bnxt *bp = netdev_priv(dev); int reg_len; + if (!BNXT_PF(bp)) + return -EOPNOTSUPP; + reg_len = BNXT_PXP_REG_LEN; if (bp->fw_cap & BNXT_FW_CAP_PCIE_STATS_SUPPORTED) |