diff options
| author |   Thomas Weißschuh <linux@weissschuh.net> | 2024-08-07 23:51:44 +0200 |
|---|---|---|
| committer | Thomas Weißschuh <linux@weissschuh.net> | 2024-08-12 22:22:13 +0200 |
| commit | f1a58f61d88642ae1e6e97e9d72d73bc70a93cb8 (patch) | |
| tree | 034a87ff84bf9775a61e28f2a54acb715f39f437 | |
| parent | selftests/nolibc: report failure if no testcase passed (diff) | |
| download | wireguard-linux-f1a58f61d88642ae1e6e97e9d72d73bc70a93cb8.tar.xz wireguard-linux-f1a58f61d88642ae1e6e97e9d72d73bc70a93cb8.zip | |
selftests/nolibc: avoid passing NULL to printf("%s")
Clang on higher optimization levels detects that NULL is passed to
printf("%s") and warns about it.
While printf() from nolibc gracefully handles that NULL,
it is undefined behavior as per POSIX, so the warning is reasonable.
Avoid the warning by transforming NULL into a non-NULL placeholder.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Acked-by: Willy Tarreau <w@1wt.eu>
Link: https://lore.kernel.org/r/20240807-nolibc-llvm-v2-8-c20f2f5fc7c2@weissschuh.net
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
| -rw-r--r-- | tools/testing/selftests/nolibc/nolibc-test.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 0800b10fc3f7..6fba7025c5e3 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -542,7 +542,7 @@ int expect_strzr(const char *expr, int llen) { int ret = 0; - llen += printf(" = <%s> ", expr); + llen += printf(" = <%s> ", expr ? expr : "(null)"); if (expr) { ret = 1; result(llen, FAIL); @@ -561,7 +561,7 @@ int expect_strnz(const char *expr, int llen) { int ret = 0; - llen += printf(" = <%s> ", expr); + llen += printf(" = <%s> ", expr ? expr : "(null)"); if (!expr) { ret = 1; result(llen, FAIL); |