diff options
| author |   Jiri Slaby (SUSE) <jirislaby@kernel.org> | 2023-09-19 10:51:55 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-10-03 14:31:16 +0200 |
| commit | fd99392b643b824813df2edbaebe26a2136d31e6 (patch) | |
| tree | de593d2beea618be4fc14701f14713adcc4bdf51 | |
| parent | tty: early return from send_break() on TTY_DRIVER_HARDWARE_BREAK (diff) | |
| download | wireguard-linux-fd99392b643b824813df2edbaebe26a2136d31e6.tar.xz wireguard-linux-fd99392b643b824813df2edbaebe26a2136d31e6.zip | |
tty: don't check for signal_pending() in send_break()
msleep_interruptible() will check on its own. So no need to do the check
in send_break() before calling the above.
Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230919085156.1578-15-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/tty_io.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 87bb5094e0bb..24833b31b81c 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -2484,8 +2484,7 @@ static int send_break(struct tty_struct *tty, unsigned int duration) retval = tty->ops->break_ctl(tty, -1); if (retval) goto out; - if (!signal_pending(current)) - msleep_interruptible(duration); + msleep_interruptible(duration); retval = tty->ops->break_ctl(tty, 0); out: tty_write_unlock(tty); |