aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/arch/powerpc/kernel/btext.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-11-20 20:33:23 +0000
committerMichael Ellerman <mpe@ellerman.id.au>2021-11-25 11:25:29 +1100
commita1d2b210ffa52d60acabbf7b6af3ef7e1e69cda0 (patch)
treeb76aca16cd9057286771ee41c1798e7b93320546 /arch/powerpc/kernel/btext.c
parentpowerpc/cell: add missing of_node_put (diff)
downloadwireguard-linux-a1d2b210ffa52d60acabbf7b6af3ef7e1e69cda0.tar.xz
wireguard-linux-a1d2b210ffa52d60acabbf7b6af3ef7e1e69cda0.zip
powerpc/btext: add missing of_node_put
for_each_node_by_type performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression n; expression e; @@ for_each_node_by_type(n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/1448051604-25256-6-git-send-email-Julia.Lawall@lip6.fr
Diffstat (limited to 'arch/powerpc/kernel/btext.c')
-rw-r--r--arch/powerpc/kernel/btext.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c
index 803c2a45b22a..1cffb5e7c38d 100644
--- a/arch/powerpc/kernel/btext.c
+++ b/arch/powerpc/kernel/btext.c
@@ -241,8 +241,10 @@ int __init btext_find_display(int allow_nonstdout)
rc = btext_initialize(np);
printk("result: %d\n", rc);
}
- if (rc == 0)
+ if (rc == 0) {
+ of_node_put(np);
break;
+ }
}
return rc;
}