diff options
| author |   Kunwu Chan <chentao@kylinos.cn> | 2023-12-08 16:59:37 +0800 |
|---|---|---|
| committer |   Michael Ellerman <mpe@ellerman.id.au> | 2023-12-13 22:18:59 +1100 |
| commit | 9a260f2dd827bbc82cc60eb4f4d8c22707d80742 (patch) | |
| tree | b22d0581a7742ea36cdbd958912d83b033f7b70f /arch/powerpc/platforms/powernv/opal-xscom.c | |
| parent | powerpc/mm: Fix null-pointer dereference in pgtable_cache_add (diff) | |
| download | wireguard-linux-9a260f2dd827bbc82cc60eb4f4d8c22707d80742.tar.xz wireguard-linux-9a260f2dd827bbc82cc60eb4f4d8c22707d80742.zip | |
powerpc/powernv: Add a null pointer check to scom_debug_init_one()
kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.
Add a null pointer check, and release 'ent' to avoid memory leaks.
Fixes: bfd2f0d49aef ("powerpc/powernv: Get rid of old scom_controller abstraction")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231208085937.107210-1-chentao@kylinos.cn
Diffstat (limited to 'arch/powerpc/platforms/powernv/opal-xscom.c')
| -rw-r--r-- | arch/powerpc/platforms/powernv/opal-xscom.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platforms/powernv/opal-xscom.c index 262cd6fac907..748c2b97fa53 100644 --- a/arch/powerpc/platforms/powernv/opal-xscom.c +++ b/arch/powerpc/platforms/powernv/opal-xscom.c @@ -165,6 +165,11 @@ static int scom_debug_init_one(struct dentry *root, struct device_node *dn, ent->chip = chip; snprintf(ent->name, 16, "%08x", chip); ent->path.data = (void *)kasprintf(GFP_KERNEL, "%pOF", dn); + if (!ent->path.data) { + kfree(ent); + return -ENOMEM; + } + ent->path.size = strlen((char *)ent->path.data); dir = debugfs_create_dir(ent->name, root); |