diff options
| author |   Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2023-01-17 14:02:23 +0800 |
|---|---|---|
| committer |   Heiko Carstens <hca@linux.ibm.com> | 2023-01-22 18:42:34 +0100 |
| commit | b4af09140a04ab5a4a20b3e14738ee56ddd37eff (patch) | |
| tree | 9dbab671568308d68dcb56d2ffa5efb849625539 /arch/s390/mm/vmem.c | |
| parent | s390/cio: evaluate devices with non-operational paths (diff) | |
| download | wireguard-linux-b4af09140a04ab5a4a20b3e14738ee56ddd37eff.tar.xz wireguard-linux-b4af09140a04ab5a4a20b3e14738ee56ddd37eff.zip | |
s390/vmem: use swap() instead of open coding it
Swap is a function interface that provides exchange function. To avoid
code duplication, we can use swap function.
./arch/s390/mm/vmem.c:680:10-11: WARNING opportunity for swap().
[hca@linux.ibm.com: get rid of all temp variables]
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3786
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230117060223.58583-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Diffstat (limited to 'arch/s390/mm/vmem.c')
| -rw-r--r-- | arch/s390/mm/vmem.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/arch/s390/mm/vmem.c b/arch/s390/mm/vmem.c index 78d7768f93d7..15daf777cf41 100644 --- a/arch/s390/mm/vmem.c +++ b/arch/s390/mm/vmem.c @@ -672,13 +672,7 @@ static int __init memblock_region_cmp(const void *a, const void *b) static void __init memblock_region_swap(void *a, void *b, int size) { - struct memblock_region *r1 = a; - struct memblock_region *r2 = b; - struct memblock_region swap; - - swap = *r1; - *r1 = *r2; - *r2 = swap; + swap(*(struct memblock_region *)a, *(struct memblock_region *)b); } /* |