diff options
| author |   Keith Busch <keith.busch@intel.com> | 2018-11-26 09:54:30 -0700 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2018-11-26 10:34:27 -0700 |
| commit | af78ff7c6e66832afcdf5418f67b11c409f9e7a1 (patch) | |
| tree | 22b7a66b3c246d2793180f31ffa062f6cea74e37 /block/blk-mq.c | |
| parent | scsi: Do not rely on blk-mq for double completions (diff) | |
| download | wireguard-linux-af78ff7c6e66832afcdf5418f67b11c409f9e7a1.tar.xz wireguard-linux-af78ff7c6e66832afcdf5418f67b11c409f9e7a1.zip | |
blk-mq: Simplify request completion state
There are no more users relying on blk-mq request states to prevent
double completions, so replace the relatively expensive cmpxchg operation
with WRITE_ONCE.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-mq.c')
| -rw-r--r-- | block/blk-mq.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index 7c8cfa0cd420..cda698804422 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -568,9 +568,7 @@ static void __blk_mq_complete_request(struct request *rq) bool shared = false; int cpu; - if (!blk_mq_mark_complete(rq)) - return; - + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE); /* * Most of single queue controllers, there is only one irq vector * for handling IO completion, and the only irq's affinity is set |