diff options
| author |   Kuan-Wei Chiu <visitorckw@gmail.com> | 2023-12-11 00:50:40 +0800 |
|---|---|---|
| committer |   Stephen Boyd <sboyd@kernel.org> | 2023-12-16 17:12:29 -0800 |
| commit | bfbea9e5667cfa9552c3d88f023386f017f6c308 (patch) | |
| tree | 30b10cc81e07dadb4cd11b63b48c3fcafc11cb67 /drivers/clk/hisilicon | |
| parent | clk: sp7021: fix return value check in sp7021_clk_probe() (diff) | |
| download | wireguard-linux-bfbea9e5667cfa9552c3d88f023386f017f6c308.tar.xz wireguard-linux-bfbea9e5667cfa9552c3d88f023386f017f6c308.zip | |
clk: hi3620: Fix memory leak in hi3620_mmc_clk_init()
In cases where kcalloc() fails for the 'clk_data->clks' allocation, the
code path does not handle the failure gracefully, potentially leading
to a memory leak. This fix ensures proper cleanup by freeing the
allocated memory for 'clk_data' before returning.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Link: https://lore.kernel.org/r/20231210165040.3407545-1-visitorckw@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/hisilicon')
| -rw-r--r-- | drivers/clk/hisilicon/clk-hi3620.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c index 2d7186905abd..5d0226530fdb 100644 --- a/drivers/clk/hisilicon/clk-hi3620.c +++ b/drivers/clk/hisilicon/clk-hi3620.c @@ -466,8 +466,10 @@ static void __init hi3620_mmc_clk_init(struct device_node *node) return; clk_data->clks = kcalloc(num, sizeof(*clk_data->clks), GFP_KERNEL); - if (!clk_data->clks) + if (!clk_data->clks) { + kfree(clk_data); return; + } for (i = 0; i < num; i++) { struct hisi_mmc_clock *mmc_clk = &hi3620_mmc_clks[i]; |