diff options
| author |   Wentao Liang <vulab@iscas.ac.cn> | 2025-02-11 17:20:17 +0800 |
|---|---|---|
| committer |   Bjorn Andersson <andersson@kernel.org> | 2025-04-15 21:37:39 -0500 |
| commit | 36eb51ac8bd545b6344c05a9860e4e65ba8d7a62 (patch) | |
| tree | d3f05c31d0004032320ba4292ecf5ae43fda00cd /drivers/clk/qcom | |
| parent | Linux 6.15-rc1 (diff) | |
| download | wireguard-linux-36eb51ac8bd545b6344c05a9860e4e65ba8d7a62.tar.xz wireguard-linux-36eb51ac8bd545b6344c05a9860e4e65ba8d7a62.zip | |
clk: qcom: Fix missing error check for dev_pm_domain_attach()
In the current implementation, the return value of dev_pm_domain_attach()
is not checked. This can lead to silent failures if the function fails,
as the code would continue execution and return 0, ignoring the error.
This patch adds a check for the return value of dev_pm_domain_attach().
If the function fails, an error message is logged using dev_err_probe(),
and the error is propagated to the existing error handling path `err`,
which ensures proper cleanup by calling clk_notifier_unregister().
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20250211092017.562-1-vulab@iscas.ac.cn
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Diffstat (limited to 'drivers/clk/qcom')
| -rw-r--r-- | drivers/clk/qcom/apcs-sdx55.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/clk/qcom/apcs-sdx55.c b/drivers/clk/qcom/apcs-sdx55.c index 76ece6c4a969..3ba01622d8f0 100644 --- a/drivers/clk/qcom/apcs-sdx55.c +++ b/drivers/clk/qcom/apcs-sdx55.c @@ -111,7 +111,11 @@ static int qcom_apcs_sdx55_clk_probe(struct platform_device *pdev) * driver, there seems to be no better place to do this. So do it here! */ cpu_dev = get_cpu_device(0); - dev_pm_domain_attach(cpu_dev, true); + ret = dev_pm_domain_attach(cpu_dev, true); + if (ret) { + dev_err_probe(dev, ret, "can't get PM domain: %d\n", ret); + goto err; + } return 0; |