diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-17 10:26:05 +0300 |
|---|---|---|
| committer |   Stephen Boyd <sboyd@kernel.org> | 2021-12-07 12:25:29 -0800 |
| commit | 2d4fcc5ab35fac2e995f497d62439dcbb416babc (patch) | |
| tree | 17c081cb53f5ec67a9834cff470f70282c5b945a /drivers/clk/versatile | |
| parent | clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1 (diff) | |
| download | wireguard-linux-2d4fcc5ab35fac2e995f497d62439dcbb416babc.tar.xz wireguard-linux-2d4fcc5ab35fac2e995f497d62439dcbb416babc.zip | |
clk: versatile: clk-icst: use after free on error path
This frees "name" and then tries to display in as part of the error
message on the next line. Swap the order.
Fixes: 1b2189f3aa50 ("clk: versatile: clk-icst: Ensure clock names are unique")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211117072604.GC5237@kili
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/versatile')
| -rw-r--r-- | drivers/clk/versatile/clk-icst.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c index d52f976dc875..d5cb372f0901 100644 --- a/drivers/clk/versatile/clk-icst.c +++ b/drivers/clk/versatile/clk-icst.c @@ -543,8 +543,8 @@ static void __init of_syscon_icst_setup(struct device_node *np) regclk = icst_clk_setup(NULL, &icst_desc, name, parent_name, map, ctype); if (IS_ERR(regclk)) { - kfree(name); pr_err("error setting up syscon ICST clock %s\n", name); + kfree(name); return; } of_clk_add_provider(np, of_clk_src_simple_get, regclk); |