aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/crypto
diff options
context:
space:
mode:
authorQi Tao <taoqi10@huawei.com>2024-01-26 17:38:27 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2024-02-02 18:10:05 +0800
commitdd1a502cabcaa410c68ee9f74eae50d85e89fee3 (patch)
tree7f0409792d5709ee69cbd7c40443e077c00920f6 /drivers/crypto
parentcrypto: hisilicon/sec2 - modify nested macro call (diff)
downloadwireguard-linux-dd1a502cabcaa410c68ee9f74eae50d85e89fee3.tar.xz
wireguard-linux-dd1a502cabcaa410c68ee9f74eae50d85e89fee3.zip
crypto: hisilicon/sec2 - fix some cleanup issues
This patch fixes following cleanup issues: - The return value of the function is inconsistent with the actual return type. - After the pointer type is directly converted to the `__le64` type, the program may crash or produce unexpected results. Signed-off-by: Qi Tao <taoqi10@huawei.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
-rw-r--r--drivers/crypto/hisilicon/sec2/sec_crypto.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c
index 692ba3213cc6..f7e2ba0bf160 100644
--- a/drivers/crypto/hisilicon/sec2/sec_crypto.c
+++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c
@@ -118,7 +118,7 @@ struct sec_aead {
};
/* Get an en/de-cipher queue cyclically to balance load over queues of TFM */
-static inline int sec_alloc_queue_id(struct sec_ctx *ctx, struct sec_req *req)
+static inline u32 sec_alloc_queue_id(struct sec_ctx *ctx, struct sec_req *req)
{
if (req->c_req.encrypt)
return (u32)atomic_inc_return(&ctx->enc_qcyclic) %
@@ -1371,7 +1371,7 @@ static int sec_skcipher_bd_fill_v3(struct sec_ctx *ctx, struct sec_req *req)
sec_sqe3->bd_param = cpu_to_le32(bd_param);
sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len);
- sec_sqe3->tag = cpu_to_le64(req);
+ sec_sqe3->tag = cpu_to_le64((unsigned long)req);
return 0;
}