diff options
author | 2019-05-07 13:11:07 +0100 | |
---|---|---|
committer | 2019-05-07 17:40:19 +0100 | |
commit | 1830374e1332c93f65399687b72ff55ca4d8c978 (patch) | |
tree | 8a27e5a7c46cdd38ce4ff1f01b072fa81e815dfd /drivers/gpu/drm/drm_atomic_uapi.c | |
parent | drm/i915: Remove delay for idle_work (diff) | |
download | wireguard-linux-1830374e1332c93f65399687b72ff55ca4d8c978.tar.xz wireguard-linux-1830374e1332c93f65399687b72ff55ca4d8c978.zip |
drm/i915: Cancel retire_worker on parking
Replace the racy continuation check within retire_work with a definite
kill-switch on idling. The race was being exposed by gem_concurrent_blit
where the retire_worker would be terminated too early leaving us
spinning in debugfs/i915_drop_caches with nothing flushing the
retirement queue.
Although that the igt is trying to idle from one child while submitting
from another may be a contributing factor as to why it runs so slowly...
v2: Use the non-sync version of cancel_delayed_work(), we only need to
stop it from being scheduled as we independently check whether now is
the right time to be parking.
Testcase: igt/gem_concurrent_blit
Fixes: 79ffac8599c4 ("drm/i915: Invert the GEM wakeref hierarchy")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190507121108.18377-3-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/drm_atomic_uapi.c')
0 files changed, 0 insertions, 0 deletions