diff options
| author |   Frediano Ziglio <fziglio@redhat.com> | 2015-06-03 12:09:10 +0100 |
|---|---|---|
| committer |   Dave Airlie <airlied@redhat.com> | 2015-06-05 11:00:37 +1000 |
| commit | 8451cc964c1d193b989c41a44e5e77109cc696f8 (patch) | |
| tree | bb140e729ab0e97057d4c4f430cf563eee47df6f /drivers/gpu/drm/qxl/qxl_ioctl.c | |
| parent | drm/qxl: Do not cause spice-server to clean our objects (diff) | |
| download | wireguard-linux-8451cc964c1d193b989c41a44e5e77109cc696f8.tar.xz wireguard-linux-8451cc964c1d193b989c41a44e5e77109cc696f8.zip | |
drm/qxl: Do not leak memory if qxl_release_list_add fails
If the function fails reference counter to the object is not decremented
causing leaks.
This is hard to spot as it happens only on very low memory situations.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Cc: stable@vger.kernel.org
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/qxl/qxl_ioctl.c')
| -rw-r--r-- | drivers/gpu/drm/qxl/qxl_ioctl.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c index b110883f8253..7354a4cda59d 100644 --- a/drivers/gpu/drm/qxl/qxl_ioctl.c +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c @@ -122,8 +122,10 @@ static struct qxl_bo *qxlhw_handle_to_bo(struct qxl_device *qdev, qobj = gem_to_qxl_bo(gobj); ret = qxl_release_list_add(release, qobj); - if (ret) + if (ret) { + drm_gem_object_unreference_unlocked(gobj); return NULL; + } return qobj; } |