diff options
| author |   Pan Bian <bianpan2016@163.com> | 2018-11-22 08:52:33 +0800 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2018-12-17 15:04:49 +0100 |
| commit | 6e0856d317440a950b17c00a9283114f025e5699 (patch) | |
| tree | 61f238dab07ec0d8f788a9548a4eb85c396bf7b7 /drivers/hid/intel-ish-hid | |
| parent | Input: restore EV_ABS ABS_RESERVED (diff) | |
| download | wireguard-linux-6e0856d317440a950b17c00a9283114f025e5699.tar.xz wireguard-linux-6e0856d317440a950b17c00a9283114f025e5699.zip | |
HID: intel-ish-hid: fixes incorrect error handling
The memory chunk allocated by hid_allocate_device() should be released
by hid_destroy_device(), not kfree().
Fixes: 0b28cb4bcb1("HID: intel-ish-hid: ISH HID client driver")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/intel-ish-hid')
| -rw-r--r-- | drivers/hid/intel-ish-hid/ishtp-hid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c index cd23903ddcf1..e918d78e541c 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c @@ -222,7 +222,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev, err_hid_device: kfree(hid_data); err_hid_data: - kfree(hid); + hid_destroy_device(hid); return rv; } |