diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2020-05-14 19:33:02 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-05-14 18:02:02 -0700 |
| commit | b014d0430bcfae581d07d2e90a939b0af783d3a9 (patch) | |
| tree | d16a4680d0641773760eda46f96625de793284e9 /drivers/net/dsa | |
| parent | net: phy: mdio-moxart: remove unneeded include (diff) | |
| download | wireguard-linux-b014d0430bcfae581d07d2e90a939b0af783d3a9.tar.xz wireguard-linux-b014d0430bcfae581d07d2e90a939b0af783d3a9.zip | |
net: dsa: felix: fix incorrect clamp calculation for burst
Currently burst is clamping on rate and not burst, the assignment
of burst from the clamping discards the previous assignment of burst.
This looks like a cut-n-paste error from the previous clamping
calculation on ramp. Fix this by replacing ramp with burst.
Addresses-Coverity: ("Unused value")
Fixes: 0fbabf875d18 ("net: dsa: felix: add support Credit Based Shaper(CBS) for hardware offload")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/ocelot/felix_vsc9959.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c index df4498c0e864..85e34d85cc51 100644 --- a/drivers/net/dsa/ocelot/felix_vsc9959.c +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c @@ -1360,7 +1360,7 @@ static int vsc9959_qos_port_cbs_set(struct dsa_switch *ds, int port, /* Burst unit is 4kB */ burst = DIV_ROUND_UP(cbs_qopt->hicredit, 4096); /* Avoid using zero burst size */ - burst = clamp_t(u32, rate, 1, GENMASK(5, 0)); + burst = clamp_t(u32, burst, 1, GENMASK(5, 0)); ocelot_write_gix(ocelot, QSYS_CIR_CFG_CIR_RATE(rate) | QSYS_CIR_CFG_CIR_BURST(burst), |