diff options
| author |   Herat Ramani <herat@chelsio.com> | 2020-04-01 01:16:09 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-04-01 11:15:49 -0700 |
| commit | 41aa8561ca3fc5748391f08cc5f3e561923da52c (patch) | |
| tree | 6c18a1ed78b9f9cd18047bcec13795488579f94d /drivers/net/ethernet/chelsio | |
| parent | ipv6: don't auto-add link-local address to lag ports (diff) | |
| download | wireguard-linux-41aa8561ca3fc5748391f08cc5f3e561923da52c.tar.xz wireguard-linux-41aa8561ca3fc5748391f08cc5f3e561923da52c.zip | |
cxgb4: fix MPS index overwrite when setting MAC address
cxgb4_update_mac_filt() earlier requests firmware to add a new MAC
address into MPS TCAM. The MPS TCAM index returned by firmware is
stored in pi->xact_addr_filt. However, the saved MPS TCAM index gets
overwritten again with the return value of cxgb4_update_mac_filt(),
which is wrong.
When trying to update to another MAC address later, the wrong MPS TCAM
index is sent to firmware, which causes firmware to return error,
because it's not the same MPS TCAM index that firmware had sent
earlier to driver.
So, fix by removing the wrong overwrite being done after call to
cxgb4_update_mac_filt().
Fixes: 3f8cfd0d95e6 ("cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()")
Signed-off-by: Herat Ramani <herat@chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/chelsio')
| -rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 75fde0d4d493..ad993d6ff586 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -3132,7 +3132,6 @@ static int cxgb_set_mac_addr(struct net_device *dev, void *p) return ret; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); - pi->xact_addr_filt = ret; return 0; } |