diff options
| author |   Tariq Toukan <tariqt@mellanox.com> | 2020-05-04 11:36:02 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-05-04 10:42:06 -0700 |
| commit | 40e473071dbad04316ddc3613c3a3d1c75458299 (patch) | |
| tree | 9642f9218c42aac49aeb9b14168b4648647d9d31 /drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | |
| parent | devlink: Fix reporter's recovery condition (diff) | |
| download | wireguard-linux-40e473071dbad04316ddc3613c3a3d1c75458299.tar.xz wireguard-linux-40e473071dbad04316ddc3613c3a3d1c75458299.zip | |
net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()
When ENOSPC is set the idx is still valid and gets set to the global
MLX4_SINK_COUNTER_INDEX. However gcc's static analysis cannot tell that
ENOSPC is impossible from mlx4_cmd_imm() and gives this warning:
drivers/net/ethernet/mellanox/mlx4/main.c:2552:28: warning: 'idx' may be
used uninitialized in this function [-Wmaybe-uninitialized]
2552 | priv->def_counter[port] = idx;
Also, when ENOSPC is returned mlx4_allocate_default_counters should not
fail.
Fixes: 6de5f7f6a1fa ("net/mlx4_core: Allocate default counter per port")
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c')
0 files changed, 0 insertions, 0 deletions