diff options
| author |   Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2023-08-26 11:02:51 +0100 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2023-08-28 12:55:04 -0700 |
| commit | a014c35556b9045ece8426df2b38eb3c5e1c1aa0 (patch) | |
| tree | 9a25c470f367141136e5fca13731c612542921ad /drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | |
| parent | r8152: add vendor/device ID pair for D-Link DUB-E250 (diff) | |
| download | wireguard-linux-a014c35556b9045ece8426df2b38eb3c5e1c1aa0.tar.xz wireguard-linux-a014c35556b9045ece8426df2b38eb3c5e1c1aa0.zip | |
net: stmmac: clarify difference between "interface" and "phy_interface"
Clarify the difference between "interface" and "phy_interface" in
struct plat_stmmacenet_data, both by adding a comment, and also
renaming "interface" to be "mac_interface". The difference between
these are:
MAC ----- optional PCS ----- SerDes ----- optional PHY ----- Media
^ ^
mac_interface phy_interface
Note that phylink currently only deals with phy_interface.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/E1qZq83-005tts-6K@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index ff330423ee66..35f4b1484029 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -419,9 +419,9 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) return ERR_PTR(phy_mode); plat->phy_interface = phy_mode; - plat->interface = stmmac_of_get_mac_mode(np); - if (plat->interface < 0) - plat->interface = plat->phy_interface; + plat->mac_interface = stmmac_of_get_mac_mode(np); + if (plat->mac_interface < 0) + plat->mac_interface = plat->phy_interface; /* Some wrapper drivers still rely on phy_node. Let's save it while * they are not converted to phylink. */ |