diff options
| author |   Gregory Greenman <gregory.greenman@intel.com> | 2023-10-12 15:41:48 +0300 |
|---|---|---|
| committer |   Johannes Berg <johannes.berg@intel.com> | 2023-10-23 12:25:53 +0200 |
| commit | c3745ee2e3506b75051f9d427cba24d95f75d6bf (patch) | |
| tree | 3971dd4c2ba2c7348488bd46b2714e967954ee59 /drivers/net/wireless/intel/iwlwifi/mvm/ops.c | |
| parent | wifi: mac80211: fix change_address deadlock during unregister (diff) | |
| download | wireguard-linux-c3745ee2e3506b75051f9d427cba24d95f75d6bf.tar.xz wireguard-linux-c3745ee2e3506b75051f9d427cba24d95f75d6bf.zip | |
wifi: iwlwifi: fw: increase fw_version string size
In reality 64 bytes are enough to hold fw version string,
but some compilers can complain (with W=1) that output may be
truncated when building this string with snprintf.
Increase the size to avoid this sort of warnings and state
explicitely that we want the size to be trancated to 32 bytes.
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Tested-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231012153950.f4465b4b4e2b.Idced2e8d63c492872edcde1a3ce2cdd6cc0f8eb7@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'drivers/net/wireless/intel/iwlwifi/mvm/ops.c')
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index 465090f67aaf..4390adc31a29 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -1304,7 +1304,7 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg, snprintf(mvm->hw->wiphy->fw_version, sizeof(mvm->hw->wiphy->fw_version), - "%s", fw->fw_version); + "%.31s", fw->fw_version); trans_cfg.fw_reset_handshake = fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_FW_RESET_HANDSHAKE); |