diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-04 21:34:20 +0530 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2019-08-06 14:52:24 +0200 |
| commit | 646d90c3c2c19dcc85b3d1c7c43a26e900d4074f (patch) | |
| tree | e16b5272da1da76ab39a383a771814a0b2228528 /drivers/pinctrl/freescale | |
| parent | pinctrl: nomadik: abx500: Add of_node_put() before return (diff) | |
| download | wireguard-linux-646d90c3c2c19dcc85b3d1c7c43a26e900d4074f.tar.xz wireguard-linux-646d90c3c2c19dcc85b3d1c7c43a26e900d4074f.zip | |
pinctrl: freescale: mxs: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
three places.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804160420.5309-1-nishkadg.linux@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/freescale')
| -rw-r--r-- | drivers/pinctrl/freescale/pinctrl-mxs.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.c b/drivers/pinctrl/freescale/pinctrl-mxs.c index 641b3088876f..735cedd0958a 100644 --- a/drivers/pinctrl/freescale/pinctrl-mxs.c +++ b/drivers/pinctrl/freescale/pinctrl-mxs.c @@ -488,8 +488,10 @@ static int mxs_pinctrl_probe_dt(struct platform_device *pdev, if (of_property_read_u32(child, "reg", &val)) { ret = mxs_pinctrl_parse_group(pdev, child, idxg++, NULL); - if (ret) + if (ret) { + of_node_put(child); return ret; + } continue; } @@ -499,15 +501,19 @@ static int mxs_pinctrl_probe_dt(struct platform_device *pdev, f->ngroups, sizeof(*f->groups), GFP_KERNEL); - if (!f->groups) + if (!f->groups) { + of_node_put(child); return -ENOMEM; + } fn = child->name; i = 0; } ret = mxs_pinctrl_parse_group(pdev, child, idxg++, &f->groups[i++]); - if (ret) + if (ret) { + of_node_put(child); return ret; + } } return 0; |