diff options
| author |   SongJingyi <u201912584@hust.edu.cn> | 2023-03-24 11:14:06 +0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2023-03-24 19:17:22 -0700 |
| commit | f33642224e38d7e0d59336e10e7b4e370b1c4506 (patch) | |
| tree | d2e6169e4f7cd77dd6119b603745185dfaafa9a4 /drivers/ptp | |
| parent | vmxnet3: use gro callback when UPT is enabled (diff) | |
| download | wireguard-linux-f33642224e38d7e0d59336e10e7b4e370b1c4506.tar.xz wireguard-linux-f33642224e38d7e0d59336e10e7b4e370b1c4506.zip | |
ptp_qoriq: fix memory leak in probe()
Smatch complains that:
drivers/ptp/ptp_qoriq.c ptp_qoriq_probe()
warn: 'base' from ioremap() not released.
Fix this by revising the parameter from 'ptp_qoriq->base' to 'base'.
This is only a bug if ptp_qoriq_init() returns on the
first -ENODEV error path.
For other error paths ptp_qoriq->base and base are the same.
And this change makes the code more readable.
Fixes: 7f4399ba405b ("ptp_qoriq: fix NULL access if ptp dt node missing")
Signed-off-by: SongJingyi <u201912584@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230324031406.1895159-1-u201912584@hust.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/ptp')
| -rw-r--r-- | drivers/ptp/ptp_qoriq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c index 61530167efe4..350154e4c2b5 100644 --- a/drivers/ptp/ptp_qoriq.c +++ b/drivers/ptp/ptp_qoriq.c @@ -637,7 +637,7 @@ static int ptp_qoriq_probe(struct platform_device *dev) return 0; no_clock: - iounmap(ptp_qoriq->base); + iounmap(base); no_ioremap: release_resource(ptp_qoriq->rsrc); no_resource: |