diff options
| author |   Wen Yang <wenyang@linux.alibaba.com> | 2019-11-24 22:58:35 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-11-27 12:53:48 +0000 |
| commit | 4affd79a125ac91e6a53be843ea3960a8fc00cbb (patch) | |
| tree | bb42d14a7ee8ee531d8332ad4280b1747aeaf371 /drivers/regulator | |
| parent | regulator: da9062: Return REGULATOR_MODE_INVALID for invalid mode (diff) | |
| download | wireguard-linux-4affd79a125ac91e6a53be843ea3960a8fc00cbb.tar.xz wireguard-linux-4affd79a125ac91e6a53be843ea3960a8fc00cbb.zip | |
regulator: fix use after free issue
This is caused by dereferencing 'rdev' after put_device() in
the _regulator_get()/_regulator_put() functions.
This patch just moves the put_device() down a bit to avoid the
issue.
Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/20191124145835.25999-1-wenyang@linux.alibaba.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 5e6c629806e4..c80f3fd9532d 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1937,8 +1937,8 @@ struct regulator *_regulator_get(struct device *dev, const char *id, regulator = create_regulator(rdev, dev, id); if (regulator == NULL) { regulator = ERR_PTR(-ENOMEM); - put_device(&rdev->dev); module_put(rdev->owner); + put_device(&rdev->dev); return regulator; } @@ -2059,13 +2059,13 @@ static void _regulator_put(struct regulator *regulator) rdev->open_count--; rdev->exclusive = 0; - put_device(&rdev->dev); regulator_unlock(rdev); kfree_const(regulator->supply_name); kfree(regulator); module_put(rdev->owner); + put_device(&rdev->dev); } /** |