diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2020-01-16 15:48:52 +0000 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2020-01-22 16:21:11 +0800 |
| commit | 48d625e4c4cec813cdd1e439864a8ffc0b5081f1 (patch) | |
| tree | eb7664d58dacfdac132506633119f0fc2ac59cfe /drivers/tee | |
| parent | crypto: ccree - erase unneeded inline funcs (diff) | |
| download | wireguard-linux-48d625e4c4cec813cdd1e439864a8ffc0b5081f1.tar.xz wireguard-linux-48d625e4c4cec813cdd1e439864a8ffc0b5081f1.zip | |
tee: fix memory allocation failure checks on drv_data and amdtee
Currently the memory allocation failure checks on drv_data and
amdtee are using IS_ERR rather than checking for a null pointer.
Fix these checks to use the conventional null pointer check.
Addresses-Coverity: ("Dereference null return")
Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/tee')
| -rw-r--r-- | drivers/tee/amdtee/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c index be8937eb5d43..6370bb55f512 100644 --- a/drivers/tee/amdtee/core.c +++ b/drivers/tee/amdtee/core.c @@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void) } drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL); - if (IS_ERR(drv_data)) + if (!drv_data) return -ENOMEM; amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL); - if (IS_ERR(amdtee)) { + if (!amdtee) { rc = -ENOMEM; goto err_kfree_drv_data; } |