diff options
author | Jonah Palmer <jonah.palmer@oracle.com> | 2024-02-16 09:25:02 -0500 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2024-03-19 02:45:49 -0400 |
commit | 749a4016839270163efc36ecddddd01de491a16b (patch) | |
tree | 749a1be9ba8601e36a74c07e6883c96b3d35e07b /drivers/vdpa/vdpa_user/iova_domain.c | |
parent | vdpa: skip suspend/resume ops if not DRIVER_OK (diff) | |
download | wireguard-linux-749a4016839270163efc36ecddddd01de491a16b.tar.xz wireguard-linux-749a4016839270163efc36ecddddd01de491a16b.zip |
vdpa/mlx5: Allow CVQ size changes
The MLX driver was not updating its control virtqueue size at set_vq_num
and instead always initialized to MLX5_CVQ_MAX_ENT (16) at
setup_cvq_vring.
Qemu would try to set the size to 64 by default, however, because the
CVQ size always was initialized to 16, an error would be thrown when
sending >16 control messages (as used-ring entry 17 is initialized to 0).
For example, starting a guest with x-svq=on and then executing the
following command would produce the error below:
# for i in {1..20}; do ifconfig eth0 hw ether XX:xx:XX:xx:XX:XX; done
qemu-system-x86_64: Insufficient written data (0)
[ 435.331223] virtio_net virtio0: Failed to set mac address by vq command.
SIOCSIFHWADDR: Invalid argument
Acked-by: Dragos Tatulea <dtatulea@nvidia.com>
Acked-by: Eugenio PĂ©rez <eperezma@redhat.com>
Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
Message-Id: <20240216142502.78095-1-jonah.palmer@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
Fixes: 5262912ef3cf ("vdpa/mlx5: Add support for control VQ and MAC setting")
Diffstat (limited to 'drivers/vdpa/vdpa_user/iova_domain.c')
0 files changed, 0 insertions, 0 deletions