aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/video/fbdev/core
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-08-24 22:54:21 +0300
committerTomi Valkeinen <tomi.valkeinen@ti.com>2015-09-01 13:52:23 +0300
commitb4df20474ff76b4dbab7d991de271820383995b8 (patch)
tree380af2745a04d4862f563d3fbb78d94f8b8366f3 /drivers/video/fbdev/core
parentvideo: fbdev: s3c-fb: Constify platform_device_id (diff)
downloadwireguard-linux-b4df20474ff76b4dbab7d991de271820383995b8.tar.xz
wireguard-linux-b4df20474ff76b4dbab7d991de271820383995b8.zip
fbdev: fix snprintf() limit in show_bl_curve()
The limit should be "PAGE_SIZE - len" instead of PAGE_SIZE. Also let's use scnprintf() because snprintf() returns the number of bytes which would have been printed if there were space and scnprintf() returns the number of bytes actually printed. I don't think we are ever going to actually hit this limit in real life. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video/fbdev/core')
-rw-r--r--drivers/video/fbdev/core/fbsysfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/core/fbsysfs.c b/drivers/video/fbdev/core/fbsysfs.c
index 60c3f0a16341..15755ce1d26c 100644
--- a/drivers/video/fbdev/core/fbsysfs.c
+++ b/drivers/video/fbdev/core/fbsysfs.c
@@ -485,7 +485,7 @@ static ssize_t show_bl_curve(struct device *device,
mutex_lock(&fb_info->bl_curve_mutex);
for (i = 0; i < FB_BACKLIGHT_LEVELS; i += 8)
- len += snprintf(&buf[len], PAGE_SIZE, "%8ph\n",
+ len += scnprintf(&buf[len], PAGE_SIZE - len, "%8ph\n",
fb_info->bl_curve + i);
mutex_unlock(&fb_info->bl_curve_mutex);