diff options
| author |   Shannon Nelson <snelson@pensando.io> | 2020-03-19 19:31:49 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-03-21 19:56:04 -0700 |
| commit | 2530ba5af6040b24ad94818a188df1083a9aac0f (patch) | |
| tree | a7603d4d7f6c69925e5f274d4a76eda91f2686a1 /drivers | |
| parent | ionic: add timeout error checking for queue disable (diff) | |
| download | wireguard-linux-2530ba5af6040b24ad94818a188df1083a9aac0f.tar.xz wireguard-linux-2530ba5af6040b24ad94818a188df1083a9aac0f.zip | |
ionic: leave dev cmd request contents alone on FW timeout
It is possible (but unlikely) that FW was busy and missed a heartbeat
check but is still alive and will process the pending request, so don't
clean the dev_cmd in this case. This occasionally occurs when working
with a card that is supporting many devices and is trying to shut them
all down at once, but still wants to see that last LIF disable request.
Fixes: 97ca486592c0 ("ionic: add heartbeat check")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/pensando/ionic/ionic_main.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers/net/ethernet/pensando/ionic/ionic_main.c index c5e3d7639f7e..a0dc100b12e6 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c @@ -360,7 +360,10 @@ try_again: done, duration / HZ, duration); if (!done && hb) { - ionic_dev_cmd_clean(ionic); + /* It is possible (but unlikely) that FW was busy and missed a + * heartbeat check but is still alive and will process this + * request, so don't clean the dev_cmd in this case. + */ dev_warn(ionic->dev, "DEVCMD %s (%d) failed - FW halted\n", ionic_opcode_to_str(opcode), opcode); return -ENXIO; |