aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers
diff options
context:
space:
mode:
authorSteven Price <steven.price@arm.com>2021-07-14 15:33:00 +0100
committerSteven Price <steven.price@arm.com>2021-07-15 10:54:04 +0100
commit6f9223a56fabc840836b49de27dc7b27642c6a32 (patch)
treeff4ccf661e8d7ee46f5b9f3fcc69c69b05727da5 /drivers
parentdrm/omapdrm: Remove outdated comment (diff)
downloadwireguard-linux-6f9223a56fabc840836b49de27dc7b27642c6a32.tar.xz
wireguard-linux-6f9223a56fabc840836b49de27dc7b27642c6a32.zip
drm/of: free the iterator object on failure
When bailing out due to the sanity check the iterator value needs to be freed because the early return prevents for_each_child_of_node() from doing the dereference itself. Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") Signed-off-by: Steven Price <steven.price@arm.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210714143300.20632-1-steven.price@arm.com
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpu/drm/drm_of.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index 197c57477344..997b8827fed2 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -331,8 +331,10 @@ static int drm_of_lvds_get_remote_pixels_type(
* configurations by passing the endpoints explicitly to
* drm_of_lvds_get_dual_link_pixel_order().
*/
- if (!current_pt || pixels_type != current_pt)
+ if (!current_pt || pixels_type != current_pt) {
+ of_node_put(endpoint);
return -EINVAL;
+ }
}
return pixels_type;