diff options
| author |   Yanqing Wang <ot_yanqing.wang@mediatek.com> | 2025-05-28 15:53:51 +0800 |
|---|---|---|
| committer |   Paolo Abeni <pabeni@redhat.com> | 2025-05-29 12:22:25 +0200 |
| commit | ba99c627aac85bc746fb4a6e2d79edb3ad100326 (patch) | |
| tree | 8b6d8e98cfbb75b8ab6751e0c84e8b9add28abfc /drivers | |
| parent | hinic3: Remove printed message during module init (diff) | |
| download | wireguard-linux-ba99c627aac85bc746fb4a6e2d79edb3ad100326.tar.xz wireguard-linux-ba99c627aac85bc746fb4a6e2d79edb3ad100326.zip | |
driver: net: ethernet: mtk_star_emac: fix suspend/resume issue
Identify the cause of the suspend/resume hang: netif_carrier_off()
is called during link state changes and becomes stuck while
executing linkwatch_work().
To resolve this issue, call netif_device_detach() during the Ethernet
suspend process to temporarily detach the network device from the
kernel and prevent the suspend/resume hang.
Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Yanqing Wang <ot_yanqing.wang@mediatek.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Signed-off-by: Biao Huang <biao.huang@mediatek.com>
Link: https://patch.msgid.link/20250528075351.593068-1-macpaul.lin@mediatek.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_star_emac.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index b175119a6a7d..b83886a41121 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -1463,6 +1463,8 @@ static __maybe_unused int mtk_star_suspend(struct device *dev) if (netif_running(ndev)) mtk_star_disable(ndev); + netif_device_detach(ndev); + clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks); return 0; @@ -1487,6 +1489,8 @@ static __maybe_unused int mtk_star_resume(struct device *dev) clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks); } + netif_device_attach(ndev); + return ret; } |