diff options
| author |   Jan Kara <jack@suse.cz> | 2023-06-01 12:58:24 +0200 |
|---|---|---|
| committer |   Christian Brauner <brauner@kernel.org> | 2023-06-02 15:00:17 +0200 |
| commit | f23ce757185319886ca80c4864ce5f81ac6cc9e9 (patch) | |
| tree | ae04f92b793f5952307ccc1dc00de2a6a06ac757 /fs/internal.h | |
| parent | Revert "f2fs: fix potential corruption when moving a directory" (diff) | |
| download | wireguard-linux-f23ce757185319886ca80c4864ce5f81ac6cc9e9.tar.xz wireguard-linux-f23ce757185319886ca80c4864ce5f81ac6cc9e9.zip | |
fs: Establish locking order for unrelated directories
Currently the locking order of inode locks for directories that are not
in ancestor relationship is not defined because all operations that
needed to lock two directories like this were serialized by
sb->s_vfs_rename_mutex. However some filesystems need to lock two
subdirectories for RENAME_EXCHANGE operations and for this we need the
locking order established even for two tree-unrelated directories.
Provide a helper function lock_two_inodes() that establishes lock
ordering for any two inodes and use it in lock_two_directories().
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Message-Id: <20230601105830.13168-4-jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/internal.h')
| -rw-r--r-- | fs/internal.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/internal.h b/fs/internal.h index bd3b2810a36b..377030a50aca 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -152,6 +152,8 @@ extern long prune_icache_sb(struct super_block *sb, struct shrink_control *sc); int dentry_needs_remove_privs(struct mnt_idmap *, struct dentry *dentry); bool in_group_or_capable(struct mnt_idmap *idmap, const struct inode *inode, vfsgid_t vfsgid); +void lock_two_inodes(struct inode *inode1, struct inode *inode2, + unsigned subclass1, unsigned subclass2); /* * fs-writeback.c |