diff options
| author |   Miklos Szeredi <mszeredi@redhat.com> | 2016-09-16 12:44:20 +0200 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2016-09-16 12:44:20 +0200 |
| commit | f2b20f6ee842313a0d681dbbf7f87b70291a6a3b (patch) | |
| tree | b4bea4c83e1968a4f69592e9a7fc15be81750a8c /fs/namei.c | |
| parent | ima: use file_dentry() (diff) | |
| download | wireguard-linux-f2b20f6ee842313a0d681dbbf7f87b70291a6a3b.tar.xz wireguard-linux-f2b20f6ee842313a0d681dbbf7f87b70291a6a3b.zip | |
vfs: move permission checking into notify_change() for utimes(NULL)
This fixes a bug where the permission was not properly checked in
overlayfs. The testcase is ltp/utimensat01.
It is also cleaner and safer to do the permission checking in the vfs
helper instead of the caller.
This patch introduces an additional ia_valid flag ATTR_TOUCH (since
touch(1) is the most obvious user of utimes(NULL)) that is passed into
notify_change whenever the conditions for this special permission checking
mode are met.
Reported-by: Aihua Zhang <zhangaihua1@huawei.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Tested-by: Aihua Zhang <zhangaihua1@huawei.com>
Cc: <stable@vger.kernel.org> # v3.18+
Diffstat (limited to 'fs/namei.c')
0 files changed, 0 insertions, 0 deletions