diff options
| author |   Vasily Averin <vvs@virtuozzo.com> | 2020-03-27 07:50:40 +0300 |
|---|---|---|
| committer |   Chuck Lever <chuck.lever@oracle.com> | 2020-04-13 10:28:21 -0400 |
| commit | e1e8399eee72e9d5246d4d1bcacd793debe34dd3 (patch) | |
| tree | 887478375ca2a2a4acfc756049bb8f29e207dd77 /fs/nfsd | |
| parent | Linux 5.7-rc1 (diff) | |
| download | wireguard-linux-e1e8399eee72e9d5246d4d1bcacd793debe34dd3.tar.xz wireguard-linux-e1e8399eee72e9d5246d4d1bcacd793debe34dd3.zip | |
nfsd: memory corruption in nfsd4_lock()
New struct nfsd4_blocked_lock allocated in find_or_allocate_block()
does not initialized nbl_list and nbl_lru.
If conflock allocation fails rollback can call list_del_init()
access uninitialized fields and corrupt memory.
v2: just initialize nbl_list and nbl_lru right after nbl allocation.
Fixes: 76d348fadff5 ("nfsd: have nfsd4_lock use blocking locks for v4.1+ lock")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'fs/nfsd')
| -rw-r--r-- | fs/nfsd/nfs4state.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index e32ecedece0f..c107caa56525 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -267,6 +267,8 @@ find_or_allocate_block(struct nfs4_lockowner *lo, struct knfsd_fh *fh, if (!nbl) { nbl= kmalloc(sizeof(*nbl), GFP_KERNEL); if (nbl) { + INIT_LIST_HEAD(&nbl->nbl_list); + INIT_LIST_HEAD(&nbl->nbl_lru); fh_copy_shallow(&nbl->nbl_fh, fh); locks_init_lock(&nbl->nbl_lock); nfsd4_init_cb(&nbl->nbl_cb, lo->lo_owner.so_client, |