diff options
| author | 2026-05-22 16:06:47 -0700 | |
|---|---|---|
| committer | 2026-05-26 08:17:57 -0700 | |
| commit | 32a9ecde62731c9f7412507709192c84dafc38d1 (patch) | |
| tree | 9d85d0a411f97072868f67c70b0bb24f3d7e33a3 /include/linux/amba/ssh:/git@git.zx2c4.com | |
| parent | ethtool: rss: fix hkey leak when indir_size is 0 (diff) | |
ethtool: rss: avoid device context leak on reply-build failure
We wait with filling the reply for new RSS context creation
until after the driver ->create_rxfh_context call. The driver
needs to fill some of the defaults in the context. The failure
of rss_fill_reply() is somewhat theoretical, but doesn't take
much effort to handle it properly. Call ->remove_rxfh_context().
If the driver's remove callback fails (some implementations like sfc
can return real command errors from firmware RPCs) - skip the xa_erase
and kfree, leaving the context in the xarray. This matches how
ethnl_rss_delete_doit() behaves.
Fixes: a166ab7816c5 ("ethtool: rss: support creating contexts via Netlink")
Link: https://patch.msgid.link/20260522230647.1705600-7-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/linux/amba/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions
