aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/include/linux/err.h
diff options
context:
space:
mode:
authorDanilo Krummrich <dakr@kernel.org>2024-08-13 00:34:34 +0200
committerAndrew Morton <akpm@linux-foundation.org>2024-09-03 21:15:37 -0700
commit1a83a716ec233990e1fd5b6fbb1200ade63bf450 (patch)
tree3fbb1818e036cb279d08dd28806676d43918349e /include/linux/err.h
parentmm/rmap: use folio->_mapcount for small folios (diff)
downloadwireguard-linux-1a83a716ec233990e1fd5b6fbb1200ade63bf450.tar.xz
wireguard-linux-1a83a716ec233990e1fd5b6fbb1200ade63bf450.zip
mm: krealloc: consider spare memory for __GFP_ZERO
As long as krealloc() is called with __GFP_ZERO consistently, starting with the initial memory allocation, __GFP_ZERO should be fully honored. However, if for an existing allocation krealloc() is called with a decreased size, it is not ensured that the spare portion the allocation is zeroed. Thus, if krealloc() is subsequently called with a larger size again, __GFP_ZERO can't be fully honored, since we don't know the previous size, but only the bucket size. Example: buf = kzalloc(64, GFP_KERNEL); memset(buf, 0xff, 64); buf = krealloc(buf, 48, GFP_KERNEL | __GFP_ZERO); /* After this call the last 16 bytes are still 0xff. */ buf = krealloc(buf, 64, GFP_KERNEL | __GFP_ZERO); Fix this, by explicitly setting spare memory to zero, when shrinking an allocation with __GFP_ZERO flag set or init_on_alloc enabled. Link: https://lkml.kernel.org/r/20240812223707.32049-1-dakr@kernel.org Signed-off-by: Danilo Krummrich <dakr@kernel.org> Acked-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: David Rientjes <rientjes@google.com> Cc: Christoph Lameter <cl@linux.com> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Pekka Enberg <penberg@kernel.org> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'include/linux/err.h')
0 files changed, 0 insertions, 0 deletions