diff options
| author |   Amir Goldstein <amir73il@gmail.com> | 2020-03-19 17:10:15 +0200 |
|---|---|---|
| committer |   Jan Kara <jack@suse.cz> | 2020-03-24 11:28:00 +0100 |
| commit | dfc2d2594e4a79204a3967585245f00644b8f838 (patch) | |
| tree | e90d5dd5034896859de3a29a2c0aaef0cafa637c /include/linux/fsnotify_backend.h | |
| parent | fsnotify: simplify arguments passing to fsnotify_parent() (diff) | |
| download | wireguard-linux-dfc2d2594e4a79204a3967585245f00644b8f838.tar.xz wireguard-linux-dfc2d2594e4a79204a3967585245f00644b8f838.zip | |
fsnotify: replace inode pointer with an object id
The event inode field is used only for comparison in queue merges and
cannot be dereferenced after handle_event(), because it does not hold a
refcount on the inode.
Replace it with an abstract id to do the same thing.
Link: https://lore.kernel.org/r/20200319151022.31456-8-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'include/linux/fsnotify_backend.h')
| -rw-r--r-- | include/linux/fsnotify_backend.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h index 337c87cf34d6..c72cbea20ef7 100644 --- a/include/linux/fsnotify_backend.h +++ b/include/linux/fsnotify_backend.h @@ -132,8 +132,7 @@ struct fsnotify_ops { */ struct fsnotify_event { struct list_head list; - /* inode may ONLY be dereferenced during handle_event(). */ - struct inode *inode; /* either the inode the event happened to or its parent */ + unsigned long objectid; /* identifier for queue merges */ }; /* @@ -526,10 +525,10 @@ extern void fsnotify_finish_user_wait(struct fsnotify_iter_info *iter_info); extern bool fsnotify_prepare_user_wait(struct fsnotify_iter_info *iter_info); static inline void fsnotify_init_event(struct fsnotify_event *event, - struct inode *inode) + unsigned long objectid) { INIT_LIST_HEAD(&event->list); - event->inode = inode; + event->objectid = objectid; } #else |