aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/include/linux/interrupt.h
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2021-03-09 09:42:04 +0100
committerThomas Gleixner <tglx@linutronix.de>2021-03-17 16:33:51 +0100
commitd2da74d1278a1b51ef18beafa9da770f0db1c617 (patch)
treee7afcf65b6ee774a9b8d9b7681611a0f6aa4fc8e /include/linux/interrupt.h
parentsoftirq: s/BUG/WARN_ONCE/ on tasklet SCHED state not set (diff)
downloadwireguard-linux-d2da74d1278a1b51ef18beafa9da770f0db1c617.tar.xz
wireguard-linux-d2da74d1278a1b51ef18beafa9da770f0db1c617.zip
tasklets: Replace barrier() with cpu_relax() in tasklet_unlock_wait()
A barrier() in a tight loop which waits for something to happen on a remote CPU is a pointless exercise. Replace it with cpu_relax() which allows HT siblings to make progress. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lore.kernel.org/r/20210309084241.249343366@linutronix.de
Diffstat (limited to 'include/linux/interrupt.h')
-rw-r--r--include/linux/interrupt.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 2b98156ec707..d689fd738152 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -672,7 +672,8 @@ static inline void tasklet_unlock(struct tasklet_struct *t)
static inline void tasklet_unlock_wait(struct tasklet_struct *t)
{
- while (test_bit(TASKLET_STATE_RUN, &(t)->state)) { barrier(); }
+ while (test_bit(TASKLET_STATE_RUN, &t->state))
+ cpu_relax();
}
#else
#define tasklet_trylock(t) 1